search

wasabeef / flutter-architecture-blueprints

Flutter Architecture Blueprints is a project that introduces MVVM architecture and project structure approaches to developing Flutter apps.
MIT License
1.61k stars 261 forks source link

Use ThemeMode instead of ThemeData #38

Closed koji-1009 closed 3 years ago

koji-1009 commented 3 years ago

What does this change?

Use the themeMode property instead of theThemeData class. ref https://api.flutter.dev/flutter/material/MaterialApp/themeMode.html

What is the value of this and can you measure success?

Screenshots (Optional)

codecov-io commented 3 years ago

Codecov Report

Merging #38 (5320158) into master (afc3ba0) will decrease coverage by 2.44%. The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   53.51%   51.07%   -2.45%     
==========================================
  Files          35       34       -1     
  Lines         469      466       -3     
==========================================
- Hits          251      238      -13     
- Misses        218      228      +10
Impacted Files Coverage Δ
lib/app.dart 38.46% <33.33%> (-3.21%) :arrow_down:
lib/ui/app_theme.dart 53.33% <72.72%> (-31.05%) :arrow_down:
lib/data/local/theme_data_source_impl.dart 100.00% <100.00%> (ø)
lib/data/repository/theme_repository_impl.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afc3ba0...5320158. Read the comment docs.

wasabeef commented 3 years ago

@koji-1009 Thanks so much, I learned a lot.