search

wasabeef / flutter-architecture-blueprints

Flutter Architecture Blueprints is a project that introduces MVVM architecture and project structure approaches to developing Flutter apps.
MIT License
1.61k stars 261 forks source link

Remove ErrorNotifier #39

Closed wasabeef closed 3 years ago

wasabeef commented 3 years ago

What does this change?

What is the value of this and can you measure success?

codecov-io commented 3 years ago

Codecov Report

Merging #39 (f84c6f1) into master (f7cf96a) will increase coverage by 2.28%. The diff coverage is 73.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   51.07%   53.36%   +2.28%     
==========================================
  Files          34       33       -1     
  Lines         466      461       -5     
==========================================
+ Hits          238      246       +8     
+ Misses        228      215      -13
Impacted Files Coverage Δ
lib/ui/app_change_notifier.dart 0.00% <0.00%> (ø)
lib/data/app_error.dart 87.50% <71.42%> (-9.28%) :arrow_down:
lib/ui/home/home_page.dart 70.58% <71.42%> (-1.29%) :arrow_down:
lib/app.dart 83.33% <75.00%> (+44.87%) :arrow_up:
lib/data/remote/news_data_source_impl.dart 100.00% <100.00%> (ø)
lib/ui/app_theme.dart 86.20% <100.00%> (+32.87%) :arrow_up:
lib/ui/home/home_view_model.dart 75.00% <100.00%> (-5.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7cf96a...f84c6f1. Read the comment docs.