wasabeef / glide-transformations

An Android transformation library providing a variety of image transformations for Glide.
Apache License 2.0
9.9k stars 1.41k forks source link

Fix CropTransformation for use case with width = 0 and height = 0 #201

Open dscoppelletti opened 2 years ago

dscoppelletti commented 2 years ago

As Glide documentation says, Transformations are meant to be statless. The transform method instead changes the properties width and height in the very first lines: each property is immutable only if its initial value is not zero. Moreover the bitmap toTransform is the original bitmap, so you should not use its size as the desired size of the resulting bitmap; you have to use the parameters outWidth and outHeight, instead.