Defer loading of keymap to make customization easier

wasamasa / eyebrowse

A simple-minded way of managing window configs in emacs

GNU General Public License v3.0

437 stars 24 forks source link

Closed TLINDEN closed 5 years ago

TLINDEN commented 5 years ago

This would fix issues like #84. With this patch, I can use the following config:

(require 'eyebrowse)
(define-key eyebrowse-mode-map (kbd "C-x C-x") 'eyebrowse-command-map)
(eyebrowse-mode t)

Maybe the documentation needs to get a better explanation though.

best, Tom

wasamasa commented 5 years ago

Thanks, but no thanks.

TLINDEN commented 5 years ago

You might consider to rework your prefix key stuff anyway, it's not behaving the emacs way. For example, if I do this:

(define-key eyebrowse-mode-map (kbd "C-x") 'eyebrowse-last-window-config)

then C-x will be bound globally to that function, it doesn't follow the prefix key. So, in order to have it configured correctly I need to make:

(global-set-key (kbd "C-x C-x C-x")   'eyebrowse-last-window-config)

(C-x C-x is my prefix key).

So, it's not behaving as I'd expect it from a regular minor mode.

best, Tom

wasamasa commented 5 years ago

This is intentional and enables the convenience bindings that work without the prefix, so all is fine here.

TLINDEN commented 5 years ago

Really, I don't want to argue with you, but if you're talking about the opnionated keys, they can still be enabled and work as documented.