search

wasamasa / gotham-theme

Code never sleeps in Gotham City.
GNU General Public License v3.0
137 stars 13 forks source link

added cfw-calender #62

Closed nullx002 closed 7 years ago

nullx002 commented 7 years ago

support for cfw-calendar added

wasamasa commented 7 years ago

One big thing sticking out: You haven't stuck the theme block into the correct position. C doesn't come after W...

Colors look good for the most part, except the interaction between the face for cfw:face-day-title and cfw:face-select. Why would putting point on a day result in its foreground color getting desaturated? It's supposed to highlight it, like by putting on a background color, but not by changing the foreground color to something less visible. Either make the foreground color unspecified or swap it for both faces.

nullx002 commented 7 years ago

tried few colours for the foreground but none worked like yellow, also removing it altogether is not helping with the highlight. moved code to C, didn't knew it was ordered alphabetically so added it just below previous code that i added. also merge and rebase works slightly differently in my version of magit than you explained but finally i figured it out after a bit of experimentation. also learned a few more things about git in the process. thanks for help.

nullx002 commented 7 years ago

sorry, done.

wasamasa commented 7 years ago

OK, one more thing: The commit message doesn't reflect your changes, please reword it to something like "Add calfw faces".

nullx002 commented 7 years ago

ok, done

wasamasa commented 7 years ago

Great, thanks!