search

wasdin / SWORD-to-JSON

Convert SWORD modules to JSON: Generate json files of many Bible versions
BSD 2-Clause "Simplified" License
41 stars 14 forks source link

Testament pointer breakdown in some translations. #3

Open Llewellynvdm opened 5 years ago

Llewellynvdm commented 5 years ago

Hi, thanks for this little handy script!

I noticed when doing a bulk build of all the Bibles that the testament combination is not working that well on line 13 so I would suggest the following fix

# load the list of books per/testament
testaments = bible_mod.get_structure()._books
# merge the books
books = []
for testament in testaments:
    books += testaments[testament]

This way it working even if there is not new or old testament books in the translation.

I have forked the repo and will be using it to setup a major update to the old getBible v1 API so not all the changes is that practical (since I am trying to hold to some v1 conventions), but if I run into any other issue I will be sure to let you know.

Llewellynvdm commented 3 years ago

I have now forked this REPO, and have largely improved it to build a whole host of Bible JSON files. We have changed the structure, and now have Chapters, Books, and whole Translations.

We have also added a hash function to easy track changes in the Modules from Crosswire, and so update files in your applications. Review and contributions are welcome....

For those who are interested https://github.com/getbible/v2_builder see ya :+1:

I would make a pull request here... but this REPO seems inactive for 3 years now.

Llewellynvdm commented 7 months ago

Checkout the new https://github.com/getBible/librarian

It is also python based, and gives you access to the Crosswire Scripture Modules as an API, see in more on the API here: https://getbible.net/docs