Change theme - Githubissues

waseefakhtar / dose-android

💊⏰ Dose is a medication reminder app for Android, built entirely using Kotlin and Jetpack Compose with MVVM + Clean Architecture

https://play.google.com/store/apps/details?id=com.waseefakhtar.doseapp

MIT License

531 stars 83 forks source link

Change theme #127

Closed Angelk90 closed 10 months ago

Angelk90 commented 10 months ago

@waseefakhtar : The current color seems too dark, especially in dark mode.

Light	Dark

Link: https://m3.material.io/theme-builder#/custom

waseefakhtar commented 10 months ago

Would this approach still work as dynamic theme? And are those screenshots taken after the new changes?

Angelk90 commented 10 months ago

@waseefakhtar : I haven't had a chance to try dynamic themes. Yes the screenshots, they are taken after the changes to which the themes have been made.

waseefakhtar commented 10 months ago

@waseefakhtar : I haven't had a chance to try dynamic themes. Yes the screenshots, they are taken after the changes to which the themes have been made.

Hmm, it looks pretty similar to how it looked before. In the interest of maintaining the current design direction and minimizing changes, I think it might be best to skip merging this particular PR.

Angelk90 commented 10 months ago

@waseefakhtar : I don't understand that quite similar. You can take screenshots of the current app in light and dark mode as you see it.

waseefakhtar commented 10 months ago

@waseefakhtar : I don't understand that quite similar. You can take screenshots of the current app in light and dark mode as you see it.

I think you're testing it on < API 31 or you've disabled dynamic color themes for your apps but the app should change the color scheme according to system colors.

Like I said, it's best to maintain the current design direction and minimize these changes for now, but thank you!