Closed ankur141295 closed 8 months ago
This looks great! 👏
Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on
libs.versions.min.sdk.version.get().toInt()
shows another declaration.
I'm not sure why the usage of some properties isn't displayed in the .toml file. However, if you command-click to open the generated file, you can still see that the declared property is being referenced. For example
Additionally, the Kotlin Compiler Version is also sourced from the .toml file, but it's marked as unused there. However, this code is preexisting and functioning properly.
This looks great! 👏 Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on
libs.versions.min.sdk.version.get().toInt()
shows another declaration.I'm not sure why the usage of some properties isn't displayed in the .toml file. However, if you command-click to open the generated file, you can still see that the declared property is being referenced. For example
Additionally, the Kotlin Compiler Version is also sourced from the .toml file, but it's marked as unused there. However, this code is preexisting and functioning properly.
Okay that makes sense! 👌
This pull request contains the following changes:
This change closes #121
@waseefakhtar Please review the changes and let me know if you have any questions.