waseefakhtar / dose-android

💊⏰ Dose is a medication reminder app for Android, built entirely using Kotlin and Jetpack Compose with MVVM + Clean Architecture
https://play.google.com/store/apps/details?id=com.waseefakhtar.doseapp
MIT License
509 stars 80 forks source link

Migrate all Gradle files from Groovy to Kotlin #132

Closed ankur141295 closed 8 months ago

ankur141295 commented 8 months ago

This pull request contains the following changes:

This change closes #121

@waseefakhtar Please review the changes and let me know if you have any questions.

ankur141295 commented 8 months ago

This looks great! 👏

Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on libs.versions.min.sdk.version.get().toInt() shows another declaration.

I'm not sure why the usage of some properties isn't displayed in the .toml file. However, if you command-click to open the generated file, you can still see that the declared property is being referenced. For example

Screenshot 2023-12-24 at 1 07 38 PM

Additionally, the Kotlin Compiler Version is also sourced from the .toml file, but it's marked as unused there. However, this code is preexisting and functioning properly.

waseefakhtar commented 8 months ago

This looks great! 👏 Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on libs.versions.min.sdk.version.get().toInt() shows another declaration.

I'm not sure why the usage of some properties isn't displayed in the .toml file. However, if you command-click to open the generated file, you can still see that the declared property is being referenced. For example Screenshot 2023-12-24 at 1 07 38 PM

Additionally, the Kotlin Compiler Version is also sourced from the .toml file, but it's marked as unused there. However, this code is preexisting and functioning properly.

Okay that makes sense! 👌