search

waseefakhtar / dose-android

💊⏰ Dose is a medication reminder app for Android, built entirely using Kotlin and Jetpack Compose with MVVM + Clean Architecture
https://play.google.com/store/apps/details?id=com.waseefakhtar.doseapp
MIT License
510 stars 83 forks source link

adding-navigate-single-top-to-navHostController #72

Closed Kayvee08 closed 11 months ago

Kayvee08 commented 11 months ago

Adding link to the issue :- https://github.com/waseefakhtar/dose-android/issues/65

waseefakhtar commented 11 months ago

This looks good @Kayvee08! The only issue now is that ASK_NOTIFICATION_PERMISSION is not passed to the next screen since there's no back stack: https://github.com/waseefakhtar/dose-android/pull/72/files#diff-45cc24ad02e2857fe4dafd267f0d8d8368ad2d362c1832b11a3a0929cbf7ad0dL55. Can you look into that?

We retrieve the value of ASK_NOTIFICATION_PERMISSION in HomeDestination.NavGraphBuilder.homeGraph and ask for notification permission in Android 13 after the medication is added to DB successfully.

@Kayvee08 I just added a fix for this. So we're all good now.