waseefakhtar / dose-android

💊⏰ Dose is a medication reminder app for Android, built entirely using Kotlin and Jetpack Compose with MVVM + Clean Architecture

https://play.google.com/store/apps/details?id=com.waseefakhtar.doseapp

MIT License

530 stars 84 forks source link

[issue-75] A big medication name hide "Take now" button from Home screen #76

Closed Wottrich closed 1 year ago

Wottrich commented 1 year ago

closes #75

Context

This pull request solve button gone when medication name is too long.

Solution

To solve it problem was needed use weight modifier property to components respect spaces between them.

I moved MedicationCard to a new archive to isolate component and create previews to test UI easily.

I also removed ViewModel and Analytics dependency from MedicationCard to the component become more easy to test.

Screenshots

preview

https://github.com/waseefakhtar/dose-android/assets/24254062/aa3c7ce0-ecb9-403a-ad8c-2a964baf9892