washed / drempelbox

0 stars 0 forks source link

Test and build workflow for Rust #4

Closed tmh-alex closed 9 months ago

tmh-alex commented 9 months ago

Workflow as suggested by GitHub

washed commented 9 months ago

@tmh-alex This fails because our audio stuff requires libasound2-dev for building. I'd suggest to use our cross based build system. This has the following advantages:

I think running tests with cross is a bit different because it uses QEMU to do the target emulation for tests, which is probably unnecessarily slow. Running the tests as it is written in the file right now using just regular old cargo is probably fine!

Suggested changes:

washed commented 9 months ago

The build for arm was working, the tests were failing because of the missing ALSA dep. Nice that cross just works. If you apt-install libasound2-dev it should work!

tmh-alex commented 9 months ago

You even wrote that in the earlier message... Where's the Picard facepalm emoji when you need it.

Regarding the arm build, I know it was working but I though the tests were failing because the execution platform doesn't support the architecture. Then again, we don't need the builds for the tests, right? If that's the case, shouldn't the tests come before the build?

washed commented 9 months ago

afaik the tests do a build anyway. But the running the tests first seems like the usual way of doing things. If you run the tests with cargo test, it will usually default to the platform you are currently on. So should be fine.

tmh-alex commented 9 months ago

🥳