search

washingtonpost / aws-tagger

AWS bulk tagging tool
MIT License
118 stars 76 forks source link

32 character limitation for ELB names #12

Open Suresh-TechM opened 6 years ago

Suresh-TechM commented 6 years ago

Hi guys, thanks for the wonderful tool. I've came across an issue while trying to tag elb/alb. I'm getting error saying ELB names should be less than 32 characters. Maybe at the time of creating the script ELB were within 32 characters but since the the use of elbv2(alb/nlb) names are longer than 32 characters. It would be great if you can modify the script to support this. Thanks.

skeller047 commented 3 years ago

Hi - I ran into this same problem. It is because there is no code to account for network loadbalancers.

Look at line 376 in 'tagger.py', if ':loadbalancer/app/' in resource_arn:

It then uses the elbv2 code, which uses the ARN to identify the load balancer. But network load balancers look like this: ':loadbalancer/net/'

This is passed to the name extraction routine, and it fails because the format of the ARN is different.

Please add this condition to the code. Thanks