search

washingtonpost / elex-live-model

a model to generate estimates of the number of outstanding votes on an election night based on the current results of the race
48 stars 5 forks source link

elex-2333-remove-nonreporting-residuals-column #39

Closed daragold closed 1 year ago

daragold commented 1 year ago

Description

There was a blank residuals column being added to the nonreporting_units matrix that was unused. This caused confusion when debugging issues with reporting and non-reporting units. Nonreporting residuals columns do not get fed into the solver (obviously, because they don't exist and its a non-reporting unit).

Jira Ticket

https://arcpublishing.atlassian.net/browse/ELEX-2333

Test Steps

Run model under several settings to make sure nothing breaks. Gaussian v. nonparametric and feature v no feature. And in a multi-state run, with and without fixed effects.

lennybronner commented 1 year ago

Do you mind adding in a link to the jira ticket, how to test that this change doesn't break anything and update the PR name so that it's easy for us to update the changelog when we do the next release?