washingtonpost / elex-live-model

a model to generate estimates of the number of outstanding votes on an election night based on the current results of the race
48 stars 5 forks source link

Remove model settings #54

Closed rishasurana closed 1 year ago

rishasurana commented 1 year ago

Description

We are passing the model settings dictionary into the constructor. We should just use self.model_settings when passing the settings to GaussianModel instead of having to pass them get_aggregate_prediction_intervals when the function is called.

Task: Remove model_settings as a parameter for all implementations of get_aggregate_prediction_intervals.

Note: I also made these changes within the Nonparametric election model in order to ensure that combined unit tests run smoothly.

Jira Ticket

https://arcpublishing.atlassian.net/browse/ELEX-2264

Test Steps

  1. pip install elex-model
  2. pip install -r requirements.txt
  3. pip install -r requirements-dev.txt
  4. Create a .env file with the variables specified in README
  5. tox