We deal with all model parameters that get passed into get_estimates the same way, independent of what model they are actually for (non-parameter, gaussian). Instead we should pass a dictionary of additional model parameters (or model settings?) to get_estimates that specify the parameters that are specific to the model pi_method.
These are:
beta : gaussian
winsorize : gaussian
robust : nonparametric
lambda_ should also be passed in that way (though can be run with either model)
Description
We deal with all model parameters that get passed into get_estimates the same way, independent of what model they are actually for (non-parameter, gaussian). Instead we should pass a dictionary of additional model parameters (or model settings?) to get_estimates that specify the parameters that are specific to the model pi_method.
These are: beta : gaussian winsorize : gaussian robust : nonparametric lambda_ should also be passed in that way (though can be run with either model)
Jira Ticket
https://arcpublishing.atlassian.net/browse/ELEX-2758
Test Steps
tox
AC
Notes
Added C901 after AC #2. The model_parameters checks can be moved to another function if we want to keep this flag.