in cli.py, check if find_dotenv() is blank, then check the current working directory with usecwd=True. Note by default, usecwd=False and that this change is only necessary on the command-line. If you're running from an interpreter (python or ipython) or Jupyter notebook, there's logic in the dotenv code to check for this and then check in the CWD. 🤷🏻♀️
clarify in the README that one should not pip install elex-model if they're doing dev work, like I did 😅 I also converted ordinal lists to numbers instead of bullets.
gets the test-model notebook to work again after getting out-of-sync with changes to CombinedDataHandler and the geographic_unit_type argument. Also in this notebook, I reduced some of the duplicate code and added %config InlineBackend.figure_format = "retina" which is an option to make graphs look moderately better on PC monitors and SIGNIFICANTLY better on Mac monitors 🤩
modify tox to run tests with both Python 3.10 and 3.11.
Jira Ticket
Part of ELEX-3101, Diane's onboarding.
Test Steps
tox, run the test-model notebook, and/or run your favorite elexmodel command.
Question
I noticed a lot of the elexmodel requirements are pretty old, for example pandas<1.5 and they're currently up to 2.1 😅 Is there any reason or would you like me to try to update the packages (in another PR of course)?
Description
Hi! 👋🏻 The changes in this PR:
cli.py, check iffind_dotenv()is blank, then check the current working directory withusecwd=True. Note by default,usecwd=Falseand that this change is only necessary on the command-line. If you're running from an interpreter (pythonoripython) or Jupyter notebook, there's logic in thedotenvcode to check for this and then check in the CWD. 🤷🏻♀️pip install elex-modelif they're doing dev work, like I did 😅 I also converted ordinal lists to numbers instead of bullets.test-modelnotebook to work again after getting out-of-sync with changes toCombinedDataHandlerand thegeographic_unit_typeargument. Also in this notebook, I reduced some of the duplicate code and added%config InlineBackend.figure_format = "retina"which is an option to make graphs look moderately better on PC monitors and SIGNIFICANTLY better on Mac monitors 🤩toxto run tests with both Python 3.10 and 3.11.Jira Ticket
Part of ELEX-3101, Diane's onboarding.
Test Steps
tox, run thetest-modelnotebook, and/or run your favoriteelexmodelcommand.Question
I noticed a lot of the
elexmodelrequirements are pretty old, for examplepandas<1.5and they're currently up to 2.1 😅 Is there any reason or would you like me to try to update the packages (in another PR of course)?