washingtonpost / elex-live-model

a model to generate estimates of the number of outstanding votes on an election night based on the current results of the race
48 stars 5 forks source link

ELEX-3055: Update all `elexmodel` requirements in an attempt to silence numpy/pandas warnings #81

Closed dmnapolitano closed 1 year ago

dmnapolitano commented 1 year ago

Description

Hello! The changes in this PR:

Jira Ticket

ELEX-3055

Test Steps

Testing this is a bit complicated until this PR on elex-solver is merged and a new elex-solver package exists, but here's what you can do locally:

You can now test using tox and/or various elexmodel commands etc. 😄 🎉

lennybronner commented 1 year ago

The unit and integration tests are currently failing. It looks to me as if elex-solver isn't being installed anymore 🤔

dmnapolitano commented 1 year ago

The unit and integration tests are currently failing. It looks to me as if elex-solver isn't being installed anymore 🤔

I know, the versions of the packages being used here are too new for the current elex-solver package. So we need a new elex-solver package so that these tests will pass 😞

lennybronner commented 1 year ago

The unit and integration tests are currently failing. It looks to me as if elex-solver isn't being installed anymore 🤔

I know, the versions of the packages being used here are too new for the current elex-solver package. So we need a new elex-solver package so that these tests will pass 😞

hmm I'm not sure I understand? Also fwiw, I am getting the same error locally 😞

dmnapolitano commented 1 year ago

The unit and integration tests are currently failing. It looks to me as if elex-solver isn't being installed anymore 🤔

I know, the versions of the packages being used here are too new for the current elex-solver package. So we need a new elex-solver package so that these tests will pass 😞

hmm I'm not sure I understand? Also fwiw, I am getting the same error locally 😞

Hmmmm, if you're having trouble running stuff locally, maybe we can look at this together because it's possible my instructions are bad 😞

But for the unit tests being run here on GitHub, maybe there's a way to do it but I'm not sure it's worth the trouble. If elex-live-model does pip install elex-solver, it will wind up with dependency conflicts because the dependencies in elex-live-model are now newer than those in the current elex-solver 2.0.0 package available on PyPI. Locally, unless you make sure you're installing your local copy of elex-solver, you'll have the same issue 😞

dmnapolitano commented 1 year ago

Ok @lennybronner you can now test this branch like you normally would 🎉 Thanks and sorry 😅