[PR] Refactor how glue positioning is handled on scroll - Githubissues

washingtonstateuniversity / WSU-spine

The spine that binds together wsu.edu

14 stars 7 forks source link

[PR] Refactor how glue positioning is handled on scroll #342

Closed jeremyfelt closed 8 years ago

jeremyfelt commented 8 years ago

Previously, there were a couple hot spots that would cause glue to jump prematurely to the top or bottom on scroll when unexpected.

This commit simplifies and reworks the logic a bit to better maintain the state of #glue when the content is larger than the navigation.

Set an upper bound for the top style attribute on #spine
Watch for any positioning above 0 and reset to 0.
Watch for any positioning outside the upper bound and reset to the upper bound.

Fixes #266.