search

washingtonstateuniversity / WSU-spine

The spine that binds together wsu.edu
14 stars 7 forks source link

html5.js is resource load error #389

Closed ghost closed 7 years ago

ghost commented 8 years ago

It was pointed out to us that http://html5shiv.googlecode.com/svn/trunk/html5.js https://github.com/washingtonstateuniversity/WSU-spine/blob/1d2417b3ca4efe8a0ef5c2343637b416bf39b836/test/preprocess/blocks/head.html#L56 is called into the Spine but it is not a supported link anymore. It may be causing resource load errors.

jeremyfelt commented 8 years ago

We can probably use https://cdnjs.cloudflare.com/ajax/libs/html5shiv/3.7.3/html5shiv.min.js instead. This should only affect users on IE8 or lower.

jeremyfelt commented 8 years ago

We have this in quite a few places in addition to the sample markup in the Spine - https://github.com/search?q=org%3Awashingtonstateuniversity+https%3A%2F%2Fhtml5shiv.googlecode.com%2Fsvn%2Ftrunk%2Fhtml5.js&type=Code

ghost commented 8 years ago

Could it be done with a find a replace?

jeremyfelt commented 8 years ago

We'll need to fix on each repo and do a pull request with the change.