washingtonstateuniversity / WSU-spine

The spine that binds together wsu.edu
14 stars 7 forks source link

Not all Spine content is in a landmark region #422

Open jeremyfelt opened 6 years ago

jeremyfelt commented 6 years ago

aXe flags our skip to navigation links and the search/contact/share tabs at the top of the Spine as being outside a landmark region.

I don't believe this is absolutely necessary for WCAG 2.0 AA compliance, as our primary navigation is covered, but it would make the framework more accessible in general.

quantumJLBass commented 6 years ago

Worth noting, we correct that by adding role="navigation" to #wsu-actions-tabs since it is a toolbar nav. It corrects the issue with little side effect. Simply changing the suggest HTML example would cover this, but

if(jQuery('#wsu-actions-tabs[role="navigation"]').length===0){
    jQuery("#wsu-actions-tabs").attr("role","navigation");
}

also corrects it automatically if left out.