washingtonstateuniversity / WSUWP-Plugin-Analytics

Provides tracking scripts and GA ID management for WSU WordPress sites.
2 stars 0 forks source link

[PR] General updates #21

Closed quantumJLBass closed 9 years ago

quantumJLBass commented 9 years ago

Changes

jeremyfelt commented 9 years ago

From the perspective of reducing the number of options:

We're probably best creating a Settings -> Analytics page at this point to reduce how overwhelming the General settings page is.

jeremyfelt commented 9 years ago

Where is the work being done on the Campus / College / Parent Unit / Unit break down?

I'd like to add that as another taxonomy to the University Taxonomy repository as it has purposes other than analytics as well. I know we plan on using this data for the people directory as well.

We can then auto fill these drop downs based on what is in the taxonomy.

quantumJLBass commented 9 years ago

•It'd be nicer to defer to the theme automatically rather than having an option for Extend Defaults

The reason I did it this way is as a user I wanted all of the defaults, but I needed to add just one more rule.

•For Use jQuery UI, what are the benefits/drawbacks of having it enabled/disabled? Can we just default to on and not present the option?

If you are not using any of the jQuery UI parts (out side of the Spine) then there is no need to load rules for it. The goal is to load as few rules as we can

•I'd like to ensure the Turn on debug option only appears in local development.

It's there to override that local check you had, so makes sense

We're probably best creating a Settings -> Analytics page

:+1:

quantumJLBass commented 9 years ago

Where is the work being done on the Campus / College / Parent Unit / Unit break down?

Bob is doing that, and yes agreed it was intended to have it in a central place.

jeremyfelt commented 9 years ago
The reason I did it this way is as a user I wanted all of the defaults, but I needed to add just one more rule.

A theme file can extend the default file, right?

If you are not using any of the jQuery UI parts (out side of the Spine) then there is no need to load rules for it. The goal is to load as few rules as we can

I'm not familiar with the jQuery UI rules. What events are being toggled with this setting?

jeremyfelt commented 9 years ago

Chatted with @jeremyBass in person.

jeremyfelt commented 9 years ago

What should happen if GA is not entered for a site? Should we remove that from the tracker data entirely or continue to provide it, just with an empty string as the tracker ID?

I think now we do the latter.

quantumJLBass commented 9 years ago

What should happen if GA is not entered for a site?

The way it has been reset is yes if there is false (no site GA provided ) that we are still pushing it out. It is not an empty string, it's "false". The reason is that it auto corrects, and although is not firing the site scope GA, it is firing the Global, and the App scopes.

jeremyfelt commented 9 years ago

RE: empty site level GA ID

It is not an empty string, it's "false".

Ahh, yes - I missed that. So we're good the way it is now I believe.

jeremyfelt commented 9 years ago

Will hard code campuses and colleges in about an hour if it doesn't get hit first.

jeremyfelt commented 9 years ago

Colleges and campuses are in.

jeremyfelt commented 9 years ago

How are we looking @jeremyBass? I'm a little hesitant to ship on Friday, but as long as we do it in early afternoon so we have time to revert, I'm good.

I'd be comfortable with 8:30am (pre open lab) or 1:30pm (post lunch) if we're game tomorrow.

quantumJLBass commented 9 years ago

@jeremyfelt , I'm not feeling all that well and I may call in tomorrow, and although I don't expect any issues, I think we should wait for Monday or Tuesday unless there is any thing pressing. We are going to do a full test tomorrow morning with our whole unit on the uxtest.web.wsu.edu site, which has the plugin basically hard coded in, so we should be able to root out any issues there if there are any.

I know even if I call in, I'll be online at some point mid day anyways so if we want to we can do the 1:30 for sure. I'm comfortable either way.

jeremyfelt commented 9 years ago

I'm much more comfortable waiting until Monday, so :+1: on that plan if it goes that way. Hope you feel better!

quantumJLBass commented 9 years ago

super sounds good and thanks I hope I do as well. I'll try to test things out first thing in the morning regardless for a final check too.

jeremyfelt commented 9 years ago

Let's go for it.