search

washingtonstateuniversity / WSUWP-Plugin-Analytics

Provides tracking scripts and GA ID management for WSU WordPress sites.
2 stars 0 forks source link

[PR] Add cookie domain text field #30

Closed quantumJLBass closed 9 years ago

quantumJLBass commented 9 years ago

Set to accommodate the need to set up a cookie that is not under the domain of .wsu.edu in the platform.

jeremyfelt commented 9 years ago

Rather than rely on an input, we could match the site's domain against wsu.edu and switch on the fly when needed.

quantumJLBass commented 9 years ago

I thought about that , but we have to then also come up with a way to know if we need it as .wsu.edu or wsu.edu with out knowing, and that I don't think we can detect in a way that would always work

jeremyfelt commented 9 years ago

Is there ever a case where randomwsuaffiliate.org should have a cookie domain of .wsu.edu set?

quantumJLBass commented 9 years ago

no but they may need .randomwsuaffiliate.org

jeremyfelt commented 9 years ago

Would setting it to always be .randomwsuaffiliate.org cause issues with tracking? We do that with wsu.edu now.

quantumJLBass commented 9 years ago

yes, and why we can't know for sure if the subdomain donation is needed or not. . is an important part here but only if your not on the root url, which we don't know if we will not have that happen.