search

washingtonstateuniversity / magazine.wsu.edu

WSU Magazine WordPress theme
1 stars 0 forks source link

[PR] Featured image information button #120

Closed philcable closed 8 years ago

philcable commented 8 years ago

Fixes #112 @jeremyfelt #reviewmerge?

philcable commented 8 years ago

Let's hold off on this until after we've had some time to brainstorm lightbox solutions.

wsmagazine commented 8 years ago

Do we have a lightbox solution for WSU-WP? Bickelhaupt is using a lightbox for a magazine project.

jeremyfelt commented 8 years ago

We used Fluidbox at some point when prepping for the COB site in our toolbox demo. That appears to be applied to gallery items on business.wsu.edu now, though it's been a while so I'm not sure where to verify. :)

Colorbox is also available pretty easily on the platform by checking the box in the custom JavaScript editor.

@jbickelhaupt what solution are you looking at?

philcable commented 8 years ago

Last we talked about it, @jbickelhaupt was using Colorbox. In the interest of time, I can go back to using it for this feature.

As for implementation, what makes the most sense? Should we use the custom JavaScript editor, or - considering issue #121 - should we queue up our own copy of Colorbox (preferably, only when needed)?

jeremyfelt commented 8 years ago

As for implementation, what makes the most sense? Should we use the custom JavaScript editor, or - considering issue #121 - should we queue up our own copy of Colorbox (preferably, only when needed)?

Let's go with our own. There's a better chance we use an updated version. :)

jbickelhaupt commented 8 years ago

@jeremyfelt, Phil is correct. I'm using Colorbox and pulling it up just like I did on that international map for College of Ed. Will get the styles and scripts rolled into the child theme before the web extra feature I'm working on launches.

philcable commented 8 years ago

I'm closing this branch in favor of https://github.com/washingtonstateuniversity/magazine.wsu.edu/pull/129, which piggybacks off of the recently merged colorbox additions.