washo4evr / Socket.io-v1.x-Library

Socket.io Library for Arduino
108 stars 58 forks source link

client.monitor() does not return true #47

Open hipotenusa opened 6 years ago

hipotenusa commented 6 years ago

Hi washo4evr,

I think that "return 1;" is missing on line 136 of "SocketIOClient.cpp" file.

Thanks!

hipotenusa commented 6 years ago

Hi guys, Any comment on this?? If this is not an issue I dont know what I am doing wrong to never get true from client.monitor() Thanks!

washo4evr commented 6 years ago

Hi,

sorry for the delay. I'm working on what would be version 2 of this library the code can be improved quite a bit

as for the client.monitor, it is just used for the data

maartenlambrecht commented 6 years ago

Hi Washo4evr, Thanks a lot for this very useful library!

In the example code it looks like client.monitor needs to be true to pass to next code:

if (client.monitor()) { lastreply = millis(); Serial.println(RID); if (RID == "atime" && Rname == "time") { Serial.print("Il est "); Serial.println(Rcontent); } }

I'm putting the code out of the if -statement to get it working.

guilhermelirio commented 5 years ago

Hi Washo4evr, Thanks a lot for this very useful library!

In the example code it looks like client.monitor needs to be true to pass to next code:

if (client.monitor()) { lastreply = millis(); Serial.println(RID); if (RID == "atime" && Rname == "time") { Serial.print("Il est "); Serial.println(Rcontent); } }

I'm putting the code out of the if -statement to get it working.

Same problem with me. =/

Any solution?

jbteja commented 4 years ago

@washo4evr ,

Think, this issue can be close. It's same as #12.