search

washo4evr / Socket.io-v1.x-Library

Socket.io Library for Arduino
108 stars 58 forks source link

Connect to a socket.io namespace #52

Open oscarcon opened 6 years ago

oscarcon commented 6 years ago

Hello, after update to the latest version, I can't use the library to connect to a socket.io namespace anymore. Does someone know how to fix it?

Ruttmann commented 6 years ago

Take a look at this PR: https://github.com/washo4evr/Socket.io-v1.x-Library/pull/35

Seems that since this PR there were namespaces support. Taking a look at the source code of the current version, all those codes related to namespaces doesn't exists anymore.

The reason: dunno... :-(

@washo4evr can you please take a look at this? I also need to use namespaces... :/

BR!

washo4evr commented 6 years ago

Hi,

Thank you for using this library. I will look into it and add support.

Ruttmann commented 6 years ago

@washo4evr , there is one thing that makes me very curious...

Why did you removed all the code added on the PR #35 ? It wasn't working?

Ruttmann commented 6 years ago

@oscarcon check this link: https://github.com/washo4evr/Socket.io-v1.x-Library/tree/7e966b7a8737b1051f9ac0da89635e1157189686

It is the last library state where there was namespaces support. I've got that code and edited my local copy of the library and now I'm able to use namespaces again.

@washo4evr Soon (I guess) I'll send a pull request to add namespaces support back again. Just doing some tests here, in order to see if there's no problems with the implementation.

BR!

oscarcon commented 6 years ago

It works! Thank you very much, @Ruttmann. I have to avoid using namespace before. Now I'm able to use it.