wasi-master / 13ft

My own custom 12ft.io replacement
https://13ft.wasimaster.me
MIT License
2.82k stars 152 forks source link

Use correct command for `docker compose` #23

Closed nicolasff closed 3 months ago

nicolasff commented 3 months ago

docker-compose (V1) has been deprecated since July 2023, and Compose V2 is its replacement. Since V2 was announced, it was always available as docker compose rather than the single command docker-compose. Modern installations of Docker no longer even ship with docker-compose itself.


📑 Context

See Docker's page titled "Migrate to Compose V2" which explains that the single command docker-compose with a hyphen was part of V1 and is now deprecated. Users should instead use docker compose, and the page mentions that this process started a while back:

From July 2023 Compose V1 stopped receiving updates. It’s also no longer available in new releases of Docker Desktop.

I can confirm that I was unable to follow the README to start 13ft, since docker-compose is not available on my machine:

$ docker-compose
zsh: command not found: docker-compose

✅ Checks

ℹ Additional Information

A possible improvement here would be to also mention docker-compose as a fallback if anyone is running a very old version of Docker, but then you'd have to decide also how long to keep this mention in the README for… overall this doesn't really seem worth it. docker-compose has been deprecated for a while and is well on its way out.

The new line added after the list is to make sure it doesn't bring the one right after next to it.

wasi-master commented 3 months ago

Thank you, and yeah I would rather keep docker compose. If someone for some reason uses a older version that's on them.

wasi-master commented 3 months ago

Sorry, mistook the close with comment button for merge with comment 😅