Closed BrianPugh closed 4 months ago
Hey @wasi-master, any chance we can get this merged in soon and get a patch release? This is the last known bug before I can release a new version of Cyclopts. Thanks!
Also, if you are looking for additional maintainers, I'd be more than happy to help out 😄 .
Thank you, The thing with rst is that I do not use rst that much in my day-to-day life so testing this is really up to the community. I am grateful for people like you who are helping me find bugs
Done
hey @wasi-master! Sorry for the PR churn, but I found another occurence of trailing newlines. This time its whenever bullet/enumerated lists are the last element rendered, as they finalize in an empty
Text()
object. The new code detects that and removes trailing emptyText()
objects (technically, I replaced it with the slightly more appropriateconsole.NewLine
object for the EDIT reason below).EDIT: Also now fixed missing newlines after bullet points. Consider the following RST text:
How it got rendered before:![Screenshot 2024-04-26 at 8 46 53 AM](https://github.com/wasi-master/rich-rst/assets/14318576/c6b112ed-b830-4ccb-8739-6c0690beed65)
How it gets rendered now:![Screenshot 2024-04-26 at 8 46 43 AM](https://github.com/wasi-master/rich-rst/assets/14318576/d99e489d-c5db-4d06-9254-ba6daa24b01f)