"View Month" shows current month when it shouldn't

[GoogleCodeExporter]

What steps will reproduce the problem?
1. select a month in the future
2. add an item
3. click 'view month'

What is the expected output? What do you see instead?
i would expect to see the month wherein i just added the item, instead i see 
the current month

What version of the product are you using? On what operating system?
2 beta 8

Please provide any additional information below.

Original issue reported on code.google.com by spamfil...@digitalinkandpaint.com on 2 Nov 2010 at 4:25

[GoogleCodeExporter]

oops - forgot to change the summary
summary should read "view month" should show the currently selected month, not 
the current (chronological) month

Original comment by spamfil...@digitalinkandpaint.com on 2 Nov 2010 at 4:29

[GoogleCodeExporter]

This is not a particularly simple issue to fix. "View Month" relies on the 
month and year variables from the URL and defaults to the current month if they 
aren't set. This is definitely an issue that should be addressed, but it's not 
high on my list of priorities currently.

Original comment by sproctor@gmail.com on 11 Nov 2010 at 3:24

• Changed title: "View Month" shows current month when it shouldn't
• Changed state: Accepted

[GoogleCodeExporter]

np, not hi-pri for me either, just a minor annoyance. 
perhaps viewing a diff date should set the current month/year, or
setting the <form action= to the current url instead of just index.php (it is 
conceded that this might be the difficult part to which you refer :-)
anyway, thanks for considering the issue.

Original comment by spamfil...@digitalinkandpaint.com on 11 Nov 2010 at 4:29

[GoogleCodeExporter]

I wrote a very simple but effective fix to this issue. It annoyed me very much 
as well, because it not only applies to adding events, but also to viewing 
existing events.

The fix basically consists of implementing the two functions 
create_event_link_with_date() and create_occurrence_link_with_date() in 
calendar.php, and using them in display_day.php, display_month.php, and 
event_submit.php.
The changes are based on PHP-Calendar 2.0 Beta9.

In display_day.php and display_month.php it fixes the problem, that the "View 
Month" link in an event opened from the day view or month view showed the wrong 
month. As a side effect you also get the "View Date" link in the event view, 
which in my oppinion should be there anyway.
In event_submit.php it does not exactly fix the issue as the reporter described 
it, because when you click on "View Month" right after clicking "Submit Event" 
it still shows the wrong month (as it did before). BUT: If you click on the 
event link in "Created event: #", it takes you to the event view which enables 
you to go to the correct month or to the correct day again.
Due to little knowledge of the project and of PHP I unfortunately wasn't able 
to fix the "View Month" link on the page right after "Submit Event".

To come to an end now, I am using php-calendar with the described modifications 
and it seems to work well. I'd be happy if my changes were helpful to some 
others.

Have fun with it,
Armin

Original comment by imagri.l...@gmail.com on 7 Mar 2011 at 2:15

Attachments:

• calendar.php
• display_day.php
• display_month.php
• event_submit.php

[GoogleCodeExporter]

Okay, I started to add your changes. Then it bothered me that if I went to say 
index.php?action=display_event&eid=111 that the "View Month" link would still 
be off. So this got me motivated to fix it the way that I thought it should be 
done. You can view the changes at 
http://code.google.com/p/php-calendar/source/detail?r=521

Original comment by sproctor@gmail.com on 7 Apr 2011 at 9:39

• Changed state: Fixed