Passing string containing '&' to HtmlPageCrawler::setText() throws warning

wasinger / htmlpagedom

jQuery-inspired DOM manipulation extension for Symfony's Crawler

MIT License

346 stars 50 forks source link

Passing string containing '&' to HtmlPageCrawler::setText() throws warning #34

Closed jacobalvarez closed 5 years ago

jacobalvarez commented 5 years ago

To reproduce:

HtmlPageCrawler::create('<span />')->setText('&');

<br />
<b>Warning</b>:  Wa72\HtmlPageDom\HtmlPageCrawler::setText(): unterminated entity reference                 in <b>C:\Apache24\htdocs\support_files\external\composer_packages\vendor\wa72\htmlpagedom\src\HtmlPageCrawler.php</b> on line <b>740</b><br />

Should HtmlPageCrawler::setText() call htmlspecialchars() on passed string?

wasinger commented 5 years ago

You are right, setText should call htmlspecialchars. I'm preparing a fix.