search

wasm3 / wasm3-rs

Rust wrapper for Wasm3, the fastest WebAssembly interpreter
MIT License
155 stars 43 forks source link

Fix sysroot flag not passed to C build #21

Closed jiayihu closed 3 years ago

jiayihu commented 3 years ago

This fixes the issue in #20 , caused by sysroot passed to bindgen but missed in the cc build. The implementation is basically taken from bindgen too: https://github.com/rust-lang/rust-bindgen/pull/1537

Veykril commented 3 years ago

Awesome, thanks a lot for looking into this! Annotated one small nitpick 😄

jiayihu commented 3 years ago

Thanks, TIL 😄 P.S. This is also my first PR in Rust 🎉 I think you'll need to rebase the PR because I accepted the suggestion using GH web interface

Veykril commented 3 years ago

No need to rebase, the GH interface just appends it as a new commit onto the branch 👍