search

wasm3 / wasm3-rs

Rust wrapper for Wasm3, the fastest WebAssembly interpreter
MIT License
160 stars 44 forks source link

Bindgen version used by wasm3-sys on crates.io doesn't match the source code #32

Closed Michael-F-Bryan closed 3 years ago

Michael-F-Bryan commented 3 years ago

This repository's source code says it uses bindgen v0.59, but the version on crates.io uses bindgen v0.54.0.

I'm not quite sure how that happened when the commit bumping the bindgen version literally says "Released 0.2.0" and we're on 0.3.0 now, but would you be able to release a new version of wasm3-sys so the dependencies line up?

At the moment I'm having issues because another dependency uses the latest bindgen version (v0.59.1) and the two bindgen versions are causing a link conflict with clang-sys.

Veykril commented 3 years ago

Ah ye I only bumped the wasm3 version, not wasm3-sys so while the repo uses 0.59 the crates.io crate still uses the old version.

I'll look into that later today.

Veykril commented 3 years ago

On another note it might make sense to just remove bindgen from the build script entirely and build the the bindings once and ship them that way, will have to check if any item signatures exposed depend on conditional compilation.

Nevermind we cannot do that due to some defines we optionally pass

Veykril commented 3 years ago

Synced the minor versions now(for clarity), uploaded wasm3@0.3.1 which now uses wasm3-sys@0.3.0 which uses bindgen 0.59.