search

wasm3 / wasm3

🚀 A fast WebAssembly interpreter and the most universal WASM runtime
https://twitter.com/wasm3_engine
MIT License
7.24k stars 456 forks source link

Add support for assert_exhaustion, action in spec tests #3

Closed vshymanskyy closed 4 years ago

vshymanskyy commented 4 years ago

Currently, when running run-spec-test.py, assert_exhaustion and action is just skipped. To support this, we need:

  1. Modify wasm3 to fail gracefully when running out of resources (stack, for now?)
  2. Update run-spec-test.py to run/verify those tests

Test:

./run-spec-test.py ./core/fac.json --line 89

Actual Result:

Warning: Skipped fac.wast:89 assert_exhaustion

Expected Result: test is passed

vshymanskyy commented 4 years ago

@kavika13 Thanks. It looks to me that "action" is more tricky to implement, as (AFAIK) the action influences the next assertion. And in some cases there are multiple actions in a row. To implement this, we would need a simple "repl" mode, where we can run several commands in a row (just thoughts).