Closed brooksmtownsend closed 10 months ago
Are you able to add integration tests for the new commands?
Good call, they aren't new commands but we should definitely have an integration test for it at least basic. I've tested with a few manual cases so I'll just turn that into an integration test :)
Failing tests because of a DNS error... will try again tomorrow
Failing tests because of a DNS error... will try again tomorrow
Failing tests because I didn't exclude them from the nix suite :)
@mattwilkinsonn added integration tests and ready for re-review
Feature or Problem
This PR is updating
wash
to use the latest control interface that supports max scale instead of counts. I verified that this version of the control interface works great with wasmCloud 0.78.0 as the breaking changes there are either backwards compatible over-the-wire or no longer involve the host (e.g. querying links and claims from the bucket directly always).I got a little carried away and made a few more changes in this PR regarding the
ctl
command in this PR. This sets us up to be able to deprecatectl
entirely instead of keeping it stable for a subset of commands:wash scale actor
command to eventually replacewash ctl scale actor
wash update actor
command to eventually replacewash ctl update actor
wash ctl apply manifest
entirely, as it's functionality that is replaced by wadm and uses a manifest format that's bespoke for this individual command. The above changes were mostly moving code towash-lib
and then exposing another top level command, e.g. mostly refactoring.Related Issues
Depends on https://github.com/wasmCloud/control-interface-client/pull/58 (this PR's checks can be re-run after that merges) RFC https://github.com/wasmCloud/wasmCloud/issues/696
Release Information
wash-lib v0.12.0 wash-cli v0.21.0
Consumer Impact
As designed, this version of
wash
will remain completely compatible with older versions of the host and work for newer released versions.Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification