Closed ahmedtadde closed 10 months ago
@connorsmith256 I made some changes to make load_app_manifest
easy to unit test...at lease relative to the whole integration testing setup i originally worked on.
@ahmedtadde Sounds good! I was about to push up a fork of your branch with the integration stuff closer to working 😅 but I much prefer the unit tests you added. They're much less fragile and easier to see what we're testing, compared to integration tests 👍
@ahmedtadde ICYMI, the unit tests failed, but just for Windows: https://github.com/wasmCloud/wash/actions/runs/6510020163/job/17685606053?pr=875
I think C:\\.....
parses as a URL. As will file://.....
on linux/macos. So you might need to swap the case order to check if it's a valid file first?
@ahmedtadde ICYMI, the unit tests failed, but just for Windows: https://github.com/wasmCloud/wash/actions/runs/6510020163/job/17685606053?pr=875
I think
C:\\.....
parses as a URL. As willfile://.....
on linux/macos. So you might need to swap the case order to check if it's a valid file first?
pushed a fix; fingers crossed
Feature or Problem
The current implementations for
put model
anddeploy model
only support a manifest sourced from the local filesystem.Related Issues
624
Release Information
v0.20.2
Consumer Impact
More options for manifest sources for the
put
anddeploy
commands.Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
AppManifestSource
load_app_manifest
works as intended using asource: AppManifestSource
Manual Verification
wash
from this branch usingcargo build --release
./target/release new actor -t hello hello
to setup the hello actor example andcd
into it.path/to/wash repo/target/release up
path/to/wash repo/target/release app deploy https://raw.githubusercontent.com/wasmCloud/examples/main/actor/hello/wadm.yaml
path/to/wash repo/target/release app del hello --delete-all
curl https://raw.githubusercontent.com/wasmCloud/examples/main/actor/hello/wadm.yaml | path/to/wash repo/target/release app deploy
orcat wadm.yaml | path/to/wash repo/target/release app deploy
path/to/wash repo/target/release app del hello --delete-all
path/to/wash repo/target/release app deploy wadm.yaml
path/to/wash repo/target/release app del hello --delete-all