[FEATURE] wash app `put` & `deploy` should support other forms of manifest input (REDO, supersedes #851)

[ahmedtadde]

Feature or Problem

The current implementations for put model and deploy model only support a manifest sourced from the local filesystem.

Related Issues

624

Release Information

v0.20.2

Consumer Impact

More options for manifest sources for the put and deploy commands.

Testing

Built on platform(s)

• [ ] x86_64-linux
• [ ] aarch64-linux
• [ ] x86_64-darwin
• [x] aarch64-darwin
• [ ] x86_64-windows

Tested on platform(s)

• [ ] x86_64-linux
• [ ] aarch64-linux
• [ ] x86_64-darwin
• [x] aarch64-darwin
• [ ] x86_64-windows

Unit Test(s)

• added test for AppManifestSource
• added test to ensure load_app_manifest works as intended using a source: AppManifestSource

Manual Verification

• build wash from this branch using cargo build --release
• run ./target/release new actor -t hello hello to setup the hello actor example and cd into it.
• run path/to/wash repo/target/release up
• run path/to/wash repo/target/release app deploy https://raw.githubusercontent.com/wasmCloud/examples/main/actor/hello/wadm.yaml
• run path/to/wash repo/target/release app del hello --delete-all
• run curl https://raw.githubusercontent.com/wasmCloud/examples/main/actor/hello/wadm.yaml | path/to/wash repo/target/release app deploy or cat wadm.yaml | path/to/wash repo/target/release app deploy
• run path/to/wash repo/target/release app del hello --delete-all
• run path/to/wash repo/target/release app deploy wadm.yaml
• run path/to/wash repo/target/release app del hello --delete-all

[ahmedtadde]

@connorsmith256 I made some changes to make load_app_manifest easy to unit test...at lease relative to the whole integration testing setup i originally worked on.

[connorsmith256]

@ahmedtadde Sounds good! I was about to push up a fork of your branch with the integration stuff closer to working 😅 but I much prefer the unit tests you added. They're much less fragile and easier to see what we're testing, compared to integration tests 👍

[connorsmith256]

@ahmedtadde ICYMI, the unit tests failed, but just for Windows: https://github.com/wasmCloud/wash/actions/runs/6510020163/job/17685606053?pr=875

I think C:\\..... parses as a URL. As will file://..... on linux/macos. So you might need to swap the case order to check if it's a valid file first?

[ahmedtadde]

@ahmedtadde ICYMI, the unit tests failed, but just for Windows: https://github.com/wasmCloud/wash/actions/runs/6510020163/job/17685606053?pr=875

I think C:\\..... parses as a URL. As will file://..... on linux/macos. So you might need to swap the case order to check if it's a valid file first?

pushed a fix; fingers crossed