wasmCloud / wash

WAsmcloud SHell - the comprehensive command-line tool for wasmCloud development
https://wasmcloud.com
Apache License 2.0
148 stars 58 forks source link

fix: `wash build` key directory setting behavior #926

Closed ahmedtadde closed 11 months ago

ahmedtadde commented 11 months ago

Feature or Problem

Despite setting key_directory field in the [actor] section of wasmcloud.toml, wash build will still either reuse or generate a new key in ~/.wash/keys. It appears to the end user that wash build command is ignoring the provided configuration.

Related Issues

620

Release Information

v0.21.1

Consumer Impact

improved correctness of the wash cli; behaves as expected.

Testing

Built on platform(s)

Tested on platform(s)

Acceptance or Integration

added test cases to ensure key directory configuration is respected and adheres to common configuration precedence rule config file field < env var < cli arg

Manual Verification

ran wash build on hello actor template repo with different key directory configuration.

connorsmith256 commented 11 months ago

@ahmedtadde LGTM! but there's a minor merge conflict 🙏

ahmedtadde commented 11 months ago

@ahmedtadde LGTM! but there's a minor merge conflict 🙏

branch is now rebased with upstream/main.