wasmCloud / wash

WAsmcloud SHell - the comprehensive command-line tool for wasmCloud development
https://wasmcloud.com
Apache License 2.0
148 stars 58 forks source link

[BUG] wash claims sign allows empty versions and revisions #958

Closed ahmedtadde closed 11 months ago

ahmedtadde commented 11 months ago

Feature or Problem

Currently, when signing an actor with wash, the version (--ver) and revision (--rev) args are not required. This will lead to claims that are missing some important information.

Related Issues

wasmCloud/wasmCloud#861

Release Information

v0.21.1

Consumer Impact

stricter wash claims sign cmd that ultimately improves the metadata output of wash inspect

Testing

Built on platform(s)

Tested on platform(s)

Acceptance or Integration

updated integration tests integration_claims_sign, integration_claims_call_alias

connorsmith256 commented 11 months ago

Hey @ahmedtadde, as of today, wash has been moved to the wasmCloud repo 🎉

Would you mind re-opening these changes against the main repo? I'm working on switching this repo to be a public archive