search

wasmCloud / wasmcloud-otp

wasmCloud host runtime that leverages Elixir/OTP and Rust to provide simple, secure, distributed application development using the actor model
Apache License 2.0
228 stars 48 forks source link

Added actors started and actors stopped events #617

Closed brooksmtownsend closed 1 year ago

brooksmtownsend commented 1 year ago

Feature or Problem

This PR adds three new events to the ActorSupervisor: actors_started, actors_start_failed, and actors_stopped. These events are published once after control interface requests to start/stop actors, once they finish, along with the total count started/stopped.

Related Issues

No issue created, but this will allow wadm to be a lot smarter in terms of knowing when a request to start/stop an actor actually completes.

Release Information

v0.63.0

Consumer Impact

These three events will be added, so consumers of the event stream will need to consider these if they subscribe to all events. As I'm writing this, I realize that I need to update the wasmCloud dashboard to ignore these.

Testing

Built on platform(s)

Tested on platform(s)

Unit Test(s)

Acceptance or Integration

Manual Verification

Tested to ensure these events publish properly and contain the proper information.

brooksmtownsend commented 1 year ago

Mac runners appear to be slow this morning, may be related to testing in #616. Tests all pass well locally /shrug

brooksmtownsend commented 1 year ago

My only real comment on this is that it feels like we're cluttering things by shuffling the lattice prefix around from call to call even though it's in state ... but I've been in this pit of despair before and know how it gets messy as soon as you leave the GenServer bounds.

Yeah I agree with you around passing the prefix around. My pit of despair is just like, if I fail to look up the host for some reason that means that I can’t even publish the event back on the same lattice prefix that I just received a request on?

brooksmtownsend commented 1 year ago

@connorsmith256 fixed to not need to pass the prefix around everywhere

brooksmtownsend commented 1 year ago

Tests should pass they are just getting an old version of host_core from cache. Deleting caches and then will re-run