search

wasmCloud / wasmcloud-otp

wasmCloud host runtime that leverages Elixir/OTP and Rust to provide simple, secure, distributed application development using the actor model
Apache License 2.0
228 stars 49 forks source link

[FEATURE] rename label syntax from `HOST_` to `WASMCLOUD_HOST_` #637

Closed brooksmtownsend closed 10 months ago

brooksmtownsend commented 1 year ago

Is your feature request related to a problem? Please describe. As @jordan-rash pointed out, the HOST_<label>=<value> environment variable syntax is likely to run into a few other tools' configuration. At least for nix users, the HOST_PATH variable is used often to link to binaries that nix needs to resolve. This can lead to cumbersome labels for hosts, so it would be better to prefix this environment variable like our others.

Describe the solution you'd like Instead of looking for environment variables with HOST_ as a prefix, look for WASMCLOUD_HOST_ as a prefix.

Describe alternatives you've considered We could leave it as-is, though this will require people who have predefined environments to either unset those variables, unset the variables in a sub-shell, or simply ignore the variables. This seems lazy 😉

Additional context We should consider the breaking change here where scripts and previous commands using HOST_ won't work anymore. We can consider deprecation, but this wouldn't resolve the issue mentioned above.

ricochet commented 1 year ago

Good call out. I prefer all env vars to have the same prefix for systems that I use.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

jordan-rash commented 1 year ago

Bad bot

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

jordan-rash commented 1 year ago

I HATE YOU BOT

connorsmith256 commented 1 year ago

@jordan-rash I didn't fix it in the OTP host, but I did for the Rust host in https://github.com/wasmCloud/wasmCloud/pull/731 :)

stale[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

thomastaylor312 commented 10 months ago

OTP is deprecated and we did this in the rust host already! Closing