wasmCloud / wasmcloud-otp

wasmCloud host runtime that leverages Elixir/OTP and Rust to provide simple, secure, distributed application development using the actor model
Apache License 2.0
228 stars 48 forks source link

bump tls_certificate_check to 1.18.1 #642

Closed Iceber closed 1 year ago

Iceber commented 1 year ago

Feature or Problem

I used elixir 1.15 in my environment

elixir --version
Erlang/OTP 25 [erts-13.2.2.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit] [dtrace]

Elixir 1.15.0 (compiled with Erlang/OTP 25)

and when I use make build it fails due to https://github.com/deadtrickster/ssl_verify_fun.erl/pull/27

$ make build
...
==> ssl_verify_fun
Compiling 7 files (.erl)
src/ssl_verify_fun_cert_helpers.erl:13:14: can't find include lib "public_key/include/public_key.hrl"
%   13| -include_lib("public_key/include/public_key.hrl").
%     |              ^

src/ssl_verify_fun_cert_helpers.erl:23:34: undefined macro 'id-ce-subjectAltName'
%   23|   AltSubject = select_extension(?'id-ce-subjectAltName', Extensions),
...

Although the latest version of tls_certificate_check is 1.19.0, it removed somethings that I wasn't sure were causing any problems, so I upgraded to 1.18.1, and from the release notes, it's safe

Built successfully in 1.14.5(OTP 25)

Related Issues

Release Information

Consumer Impact

Testing

Built on platform(s)

Tested on platform(s)

Unit Test(s)

Acceptance or Integration

Manual Verification