wasmCloud / wasmcloud.com

https://wasmCloud.com website, documentation, blog, and community meetings, built with Docusaurus.
https://wasmcloud.com
Apache License 2.0
16 stars 41 forks source link

docs: update curl commands to use the default port when app is deployed #714

Closed dorser closed 2 days ago

dorser commented 2 days ago

Feature or Problem

wash dev start the application with port 8000. However, when deploying the app with wash app deploy it'll take the port from wadm.yaml which is set to 8080 by default. This commit makes sure the curl commands in the documentation uses the default port in wadm.yaml

netlify[bot] commented 2 days ago

Deploy Preview for dreamy-golick-5f201e ready!

Name Link
Latest commit 70c12407a4d0944737a953b2d91b8e6208c23218
Latest deploy log https://app.netlify.com/sites/dreamy-golick-5f201e/deploys/67364e56600913000874b34a
Deploy Preview https://deploy-preview-714--dreamy-golick-5f201e.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dorser commented 2 days ago

Speaking with Joonas, we might want to change the examples to use 8000 (the default wash dev port) instead of the documentation.

Creating another PR.

thomastaylor312 commented 2 days ago

Ok, I'll hold off on merging this then

joonas commented 2 days ago

After some in-person conversation, we decided that https://github.com/wasmCloud/wasmCloud/pull/3611 would be the better way to go on this one, so if you're good with it @dorser, I think we should close this out in favor of merging https://github.com/wasmCloud/wasmCloud/pull/3611 instead.

dorser commented 2 days ago

💯