search

wasmerio / rusty_jsc

Rust bindings for the JavaScriptCore engine.
MIT License
99 stars 7 forks source link

"rusty_jsc::" namespace inside macro #16

Open lizzz0523 opened 1 month ago

lizzz0523 commented 1 month ago

Hello, when using rusty_jsc, I prefer to keep the rusty_jsc namespace (for example, rusty_jsc::JSValue). Most of the time, it works fine, but when using the callback macro, I found that I have to use use rusty_jsc::JSValue in the code. After checking the source code, I noticed that there is a part in the definition of the callback macro that directly uses JSValue (without the rusty_jsc namespace), and the constructor macro has a similar situation. Is there any specific reason for this?

penberg commented 1 month ago

@lizzz0523 Probably just an oversight. Feel free to send a PR to fix it up.

lizzz0523 commented 1 month ago

@penberg 👌 I have submitted a pull request, please help review it.