Rusty JSC developments - Githubissues

adrien-zinger commented 1 year ago

This PR includes a few enhancements to meet my expectations. Now I can set callbacks with arguments like:

#[callback]
fn log(context: JSContext, _function: JSObject, _this: JSObject, arguments: Vec<JSValue>) {
    arguments.iter().for_each(|value| {
        if value.is_string(&context) {
            println!("{}", value.to_string(&context));
        }
        // I also have added is_date and is_symbol
        if value.is_date(&context) {
            println!("date inthere!")
        }
    });
}

Parameters of callback functions follow a fall-through rule, 1 parameter = { context }, 2 = { context, function }, etc. But callbacks can also optionally return a JSValue, so I can define an identity function or anything similar.

#[callback]
fn echo(
    context: JSContext,
    _function: JSObject,
    _this: JSObject,
    arguments: Vec<JSValue>,
) -> JSValue {
    if let Some(argument) = arguments.first() {
        argument.clone()
    } else {
        JSValue::string(&context, "").unwrap()
    }
}

I can define a class with an internal function and write the constructor like we used to do with callbacks. The constructor definition can have up to 3 arguments corresponding to { context, this, arguments }. Then, with the resulting object, I could set parameters dynamically.

#[constructor]
fn constructor() {
    println!("into the user obj cnstructor");
}

let user_obj = JSObject::class(&context, "UserObject", Some(constructor));

The current PR contains several modifications, here is a list of all that we can find:

add constructor macro
macros can get multiple arguments
callback macro can return a JSValue
add .lock file in repository
fixing .gitignore files in sys and macros
add is_date and is_symbol
add internal documentation only for JSObjectMake
JSValue can be cloned (to review)
JSValue and JSObject can be converted into each other
JSObject can create a class
JSValue implements to/into utf8 internally
JSValue and JSObject implement a getter for the inner reference
Static functions of JSValue and JSObject take any type that implements ToString instead of a String