search

wasmerio / wasmer-pack

MIT License
49 stars 5 forks source link

Convert the generated JavaScript package from ES Modules to CommonJS #89

Closed Michael-F-Bryan closed 2 years ago

Michael-F-Bryan commented 2 years ago

This should fix the underlying issue behind https://github.com/wasmerio/vscode-wasm/issues/41.

When @syrusakbary and I were looking into why the vscode-wasm addon wouldn't load, we discovered that VS Code doesn't allow plugins written in ES Module syntax (https://github.com/microsoft/vscode/issues/130367). It'll work fine while developing, but then when you compile the *.vsix and install it, it'll silently fail to load on startup because VS Code does a require("./path/to/extension") and require() isn't compatible with ES Modules.

CC: https://github.com/wasmerio/wai/pull/13

github-actions[bot] commented 2 years ago

⏱ Workflow Timer ⏱

🤯 The run time for "Continuous Integration" has improved significantly by 2mins 29s (51.74%) 🤯

The current run time is 2mins 18s while master took 4mins 48s.