Support PHP 7.2

[suhanyujie]

Summary

What's the PHP version?

• Hello~ My PHP version is PHP 7.2.18 in CentOS 7.2. I haven't found it in the doc.
• When I build it, it replies to some error.

Additional details

• The error info like this:

  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: In function ‘void zim_WasmArrayBuffer_getByteLength(zend_execute_data*, zval*)’:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:139:32: error: ‘ZEND_PARSE_PARAMETERS_NONE’ was not declared in this scope
   ZEND_PARSE_PARAMETERS_NONE();
                              ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: In function ‘void zif_wasm_compile(zend_execute_data*, zval*)’:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:505:13: error: ‘zend_register_persistent_resource_ex’ was not declared in this scope
           );
           ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: In function ‘void zif_wasm_module_clean_up_persistent_resources(zend_execute_data*, zval*)’:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:571:32: error: ‘ZEND_PARSE_PARAMETERS_NONE’ was not declared in this scope
   ZEND_PARSE_PARAMETERS_NONE();
                              ^
  In file included from /www/server/php/72/include/php/Zend/zend.h:29:0,
               from /www/server/php/72/include/php/main/php.h:35,
               from /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.hh:23,
               from /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:19:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: At global scope:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:1062:100: error: ‘_IS_NUMBER’ was not declared in this scope
  ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_wasm_invoke_function, ZEND_RETURN_VALUE, ARITY(3), _IS_NUMBER, NULLABLE)
                                                                                                  ^
  /www/server/php/72/include/php/Zend/zend_types.h:143:5: note: in definition of macro ‘ZEND_TYPE_ENCODE’
  (((code) << Z_L(1)) | ((allow_null) ? Z_L(0x1) : Z_L(0x0)))
   ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:1062:1: note: in expansion of macro ‘ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX’
  ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_wasm_invoke_function, ZEND_RETURN_VALUE, ARITY(3), _IS_NUMBER, NULLABLE)
  ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: In function ‘void zif_wasm_get_last_error(zend_execute_data*, zval*)’:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:1475:32: error: ‘ZEND_PARSE_PARAMETERS_NONE’ was not declared in this scope
   ZEND_PARSE_PARAMETERS_NONE();
                              ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: In function ‘void zif_WasmTypedArray_get_offset(zend_execute_data*, zval*)’:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:1724:32: error: ‘ZEND_PARSE_PARAMETERS_NONE’ was not declared in this scope
   ZEND_PARSE_PARAMETERS_NONE();
                              ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: In function ‘void zif_WasmTypedArray_get_length(zend_execute_data*, zval*)’:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:1751:32: error: ‘ZEND_PARSE_PARAMETERS_NONE’ was not declared in this scope
   ZEND_PARSE_PARAMETERS_NONE();
                              ^
  In file included from /www/server/php/72/include/php/Zend/zend.h:29:0,
               from /www/server/php/72/include/php/main/php.h:35,
               from /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.hh:23,
               from /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:19:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: At global scope:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:1762:105: error: ‘_IS_NUMBER’ was not declared in this scope
  ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_wasmtypedarray_offset_get, ZEND_RETURN_VALUE, ARITY(1), _IS_NUMBER, NOT_NULLABLE)
                                                                                                       ^
  /www/server/php/72/include/php/Zend/zend_types.h:143:5: note: in definition of macro ‘ZEND_TYPE_ENCODE’
  (((code) << Z_L(1)) | ((allow_null) ? Z_L(0x1) : Z_L(0x0)))
   ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:1762:1: note: in expansion of macro ‘ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX’
  ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_wasmtypedarray_offset_get, ZEND_RETURN_VALUE, ARITY(1), _IS_NUMBER, NOT_NULLABLE)
  ^
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc: In function ‘int zm_startup_wasm(int, int)’:
  /data/alpha/rust/php-ext-wasm-0.5.0/src/wasm.cc:2104:65: error: ‘ZEND_ACC_IMMUTABLE’ was not declared in this scope
   wasm_array_buffer_class_entry->ce_flags |= ZEND_ACC_FINAL | ZEND_ACC_IMMUTABLE;
                                                               ^
  make: *** [wasm.lo] Error 1
  error: Recipe `build` failed with exit code 2

[Hywan]

Hello,

Thanks for pointing that out! I'll work on a fix.

[Hywan]

The master branch is now compatible with PHP 7.2.