wasmerio / wasmer-ruby

💎🕸 WebAssembly runtime for Ruby
https://wasmer.io
MIT License
465 stars 18 forks source link

Release version 1.0.1 #59

Open yachtcaptain23 opened 2 years ago

yachtcaptain23 commented 2 years ago

I believe https://github.com/wasmerio/wasmer-ruby/pull/58 fixes an issue for https://github.com/brave-intl/wasm-thumbnail , as it seems like the Rakefile line 12 in v1.0.0 seems to be causing issues as seen below:

#18 324.8 Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
#18 324.8
#18 324.8     current directory: /var/www/vendor/bundle/ruby/2.7.0/gems/wasmer-1.0.0
#18 324.8 /usr/local/bin/ruby -I/usr/local/lib/ruby/2.7.0/rubygems -rrubygems
#18 324.8 /var/www/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake
#18 324.8 RUBYARCHDIR\=/var/www/vendor/bundle/ruby/2.7.0/extensions/x86_64-linux-musl/2.7.0/wasmer-1.0.0
#18 324.8 RUBYLIBDIR\=/var/www/vendor/bundle/ruby/2.7.0/extensions/x86_64-linux-musl/2.7.0/wasmer-1.0.0
#18 324.8 fatal: not a git repository (or any of the parent directories): .git
#18 324.8 bundle config set --local path "vendor/bundle"
#18 324.8 bundle install
#18 324.8 The deployment setting requires a Gemfile.lock. Please make sure you have
#18 324.8 checked your Gemfile.lock into version control before deploying.
#18 324.8 rake aborted!
#18 324.8 Command failed with status (16): [bundle install...]
#18 324.8 /var/www/vendor/bundle/ruby/2.7.0/gems/wasmer-1.0.0/Rakefile:12:in `block in
#18 324.8 <top (required)>'
#18 324.8 /var/www/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<main>'
#18 324.8 Tasks: TOP => default => test => bundle_install
#18 324.8 (See full trace by running task with --trace)

Given it's a low risk change, would you be able to release 1.0.1?

yachtcaptain23 commented 2 years ago

Hey @Hywan would you be able to triage this? Thank you