search

wasmerio / wasmer

🚀 The leading Wasm Runtime supporting WASIX, WASI and Emscripten
https://wasmer.io
MIT License
18.57k stars 794 forks source link

Move wasi-types crate into wasi::types #3596

Closed fschutt closed 4 months ago

fschutt commented 1 year ago

It would be better to move the lib/wasi-types crate into lih/wasi in order to reduce the dependency of wasi-types onto the main wasmer crate (already fixed in master, but it's not very clean right now). This used to cause circular dependencies with wasmer-js.

See https://github.com/wasmerio/wasmer/pull/3468 (discontinued) for a WIP "proper" fix.

ptitSeb commented 1 year ago

We should wait and see how things evolved (for example it might be usefull for bindings).

ptitSeb commented 1 year ago

@syrusakbary what are your thoughts about this?

syrusakbary commented 1 year ago

Yeah, happy to move wasi-types into wasi (I think it will remove some coupling)

theduke commented 1 year ago

It's not necessarily what we want, because there can/will be other consumers that need to work with the same types.

Like the wasix crate and the Rust std implementation.

At the moment these use their own types, I believe, but it would be preferable to not have duplication there.

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 months ago

Feel free to reopen the issue if it has been closed by mistake.