search

wasmi-labs / wasmi

WebAssembly (Wasm) interpreter.
https://wasmi-labs.github.io/wasmi/
Apache License 2.0
1.52k stars 274 forks source link

No longer validate Wasm module header in `Module::new_unchecked` #1025

Closed Robbepop closed 1 month ago

Robbepop commented 1 month ago

Benchmarks showed that validation of the data section can be very costly for some Wasm binaries and furthermore the data section does strictly not belong to the Wasm module header. Therefore it makes sense to no longer validate it in header-only validation mode.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 82.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 80.79%. Comparing base (6214e51) to head (c39530e).

Files Patch % Lines
crates/wasmi/src/module/parser.rs 82.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1025 +/- ## ========================================== + Coverage 80.77% 80.79% +0.02% ========================================== Files 269 269 Lines 24788 24802 +14 ========================================== + Hits 20022 20040 +18 + Misses 4766 4762 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.