Closed Robbepop closed 1 month ago
Attention: Patch coverage is 81.86275%
with 37 lines
in your changes are missing coverage. Please review.
Project coverage is 80.86%. Comparing base (
3880d86
) to head (4c66abc
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
So far Wasmi only supported streaming parsing, validation and compilation of Wasm modules via
Module::new
.This PR renames both
Module::new
andModule::new_unchecked
tonew_streaming
andnew_streaming_unchecked
respectively. Also it adds 2 new methodsModule::new
andModule::new_unchecked
that take awasm: &[u8]
byte slice argument instead of astream: impl Read
argument. The idea behind this change is that if streaming compilation is not necessary we can optimize the process.Benchmarks
The benchmarks locally show amazing performance wins across the board. For
lazy
and especiallylazy-unchecked
compilation I consistently saw improvements between 40-80% (5x speed-up).