search

wasmi-labs / wasmi

WebAssembly (Wasm) interpreter.
https://wasmi-labs.github.io/wasmi/
Apache License 2.0
1.52k stars 274 forks source link

Implement `std::error::Error` for all error types that implement `Display` #1089

Closed kajacx closed 1 week ago

kajacx commented 1 week ago

I added an Error impl for all errors that implement Display. I am planning on making another pull request that implements Display and Error for the remaining errors later.

Robbepop commented 1 week ago

@kajacx Hey, thank you this is great! I usually forget to add this trait implementation because in no_std mode it is currently unavailable. However, this is hopefully changing very soon.

It would be great if you could add the trait impls for the missing error types, too.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.48%. Comparing base (5ef1e8d) to head (e20e51a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1089 +/- ## ======================================= Coverage 80.48% 80.48% ======================================= Files 270 270 Lines 25080 25080 ======================================= Hits 20186 20186 Misses 4894 4894 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Robbepop commented 1 week ago

I will merge this PR so you can do the planned Display and Error impls in a follow-up PR if you like. :) Thanks again for your contribution!