search

wasmi-labs / wasmi

WebAssembly (Wasm) interpreter.
https://wasmi-labs.github.io/wasmi/
Apache License 2.0
1.6k stars 284 forks source link

Rust version in `Cargo.toml` is out of date #1153

Closed laurmaedje closed 1 month ago

laurmaedje commented 2 months ago

When building with 1.77 as specified in Cargo.toml, you get this:

error[E0658]: associated type bounds are unstable
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasmi-0.36.0/src/module/instantiate/mod.rs:54:40
   |
54 |         I: IntoIterator<Item = Extern, IntoIter: ExactSizeIterator>,
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #52662 <https://github.com/rust-lang/rust/issues/52662> for more information

Associated type bounds were stabilized in 1.79.

Robbepop commented 2 months ago

Hi @laurmaedje thank you for reporting this. Ideally we should start to check the minimum rust version in our CI to prevent this from happening again.

laurmaedje commented 2 months ago

Agreed! We do in Typst and that's how I actually found out about this.

Robbepop commented 1 month ago

@laurmaedje I just implemented a small CI job to guard against this.

Have you had to deal with this? https://github.com/wasmi-labs/wasmi/pull/1196 If so, how do you handle these (annoying) alerts?

laurmaedje commented 1 month ago

I personally find dependabot annoying in general, so I've disabled it completely.

Maybe you can trick it by using something like this:

- uses: dtolnay/rust-toolchain@master
  with:
    toolchain: 1.79

Also confusing that it wants 1.90... since that Rust version isn't out for a while.